refactor(audience-sample-app): drop log row count cap#714
Merged
ImmutableJeffrey merged 1 commit intofeat/audience-sample-appfrom Apr 28, 2026
Merged
Conversation
Removes the LogCapacity const (200) and the eviction check inside AppendLog. Log rows now accumulate until the user clicks Clear or the session ends. Sample-app demo sessions are short and the cap was preventive rather than corrective.
ImmutableJeffrey
force-pushed
the
refactor/audience-sample-app-drop-log-row-cap
branch
from
5a24d4f to
2748697
Compare
ImmutableJeffrey
changed the base branch from
refactor/audience-sdk-drop-error-body-cap
to
feat/audience-sample-app
nattb8
approved these changes
Apr 28, 2026
ImmutableJeffrey
deleted the
refactor/audience-sample-app-drop-log-row-cap
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes the
LogCapacityconst (200) and the eviction check insideAppendLoginAudienceSample.UI.cs. Log rows now accumulate until the user clicks Clear or the session ends. The cap was preventive (defending against unbounded UI growth in long sessions) rather than corrective — sample-app demo sessions are short and the visual tree handles thousands of rows comfortably.Stacked on top of #711. Base =
feat/audience-sample-app. Once 711 merges, this PR's base will auto-rebase tomain.Linear: SDK-152